All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Grebus <Gary.Grebus@oracle.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: Re: [PATCH 0 of 1] Deal with Serial Over LAN (SOL) IPMI	interfaces.
Date: Mon, 14 Dec 2009 19:03:29 -0500	[thread overview]
Message-ID: <4B26D251.8000000@oracle.com> (raw)
In-Reply-To: <C74C1A89.466B%keir.fraser@eu.citrix.com>

Keir Fraser wrote:
> On 14/12/2009 15:10, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
> 
>> During the testing of Intel blades we found that the Serial Over LAN
>> does not generate IRQs that well. Gary came up with a patch that
>> figures out if it needs to poll or just work as before (IRQ). The benefit
>> of this patch is that you don't need to do:
>>
>> com1=115200,8n1,0
>>
>> but instead can just do com1=115200,8n1 which is great in the field
>> where you don't want the bootup file to change.
> 
> Kinda gross, and I'm not sure it's straightforward enough that I trust it on
> all systems that currently work fine (vast majority). I *might* consider it
> if it's a non-default boot option to turn it on. I don't believe that Linux
> does such things either, at least by default.

The Linux 8250.c driver does something vaguely similar when initializing a UART.  It explicitly
transmits a character to force an interrupt to test that the THRE bit is handled correctly.

I thought it a bit more risky to add an explicit sequence to test for the interrupt....
just start with polling enabled, and if the interrupt shows up it's ok to stop polling.
But as you say, it's a small minority of systems that have this problem anyway (IIRC, we saw this
for an Intel Clearbay platform).

	/gary

      parent reply	other threads:[~2009-12-15  0:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 15:10 [PATCH 0 of 1] Deal with Serial Over LAN (SOL) IPMI interfaces Konrad Rzeszutek Wilk
2009-12-14 15:10 ` [PATCH 1 of 1] Handle bogus serial ports that appear normal, but don't generate Konrad Rzeszutek Wilk
2009-12-14 16:38 ` [PATCH 0 of 1] Deal with Serial Over LAN (SOL) IPMI interfaces Keir Fraser
2009-12-14 16:36   ` Konrad Rzeszutek Wilk
2009-12-14 22:48     ` Pasi Kärkkäinen
2009-12-15  0:03   ` Gary Grebus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B26D251.8000000@oracle.com \
    --to=gary.grebus@oracle.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.