From: Alexander Graf <agraf@suse.de>
To: Avi Kivity <avi@redhat.com>
Cc: Sheng Yang <sheng@linux.intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Trap and invalid MWAIT/MONITOR instruction
Date: Tue, 15 Dec 2009 10:36:53 +0100 [thread overview]
Message-ID: <4B2758B5.3040105@suse.de> (raw)
In-Reply-To: <4B275599.6050002@redhat.com>
Avi Kivity wrote:
> On 12/15/2009 09:36 AM, Alexander Graf wrote:
>> On 15.12.2009, at 06:29, Sheng Yang wrote:
>>
>>
>>> We don't support these instructions, but guest can execute them even
>>> if the
>>> feature('monitor') haven't been exposed in CPUID. So we would trap
>>> and inject
>>> a #UD if guest try this way.
>>>
>> Wouldn't it be a lot better to emulate them? I actually have
>> emulation of MONITOR/MWAIT on my todo list for some time, since OSX
>> requires it.
>>
>> Basically what they do is they guarantee that a MONITOR'ed region is
>> on a page boundary, so all we need to do is not map the monitor'ed
>> page to wake up from the mwait.
>>
>
> You'll need to break up large page mappings for this.
Right. Same for PCI device assignment. Breaking up large page mappings
should be a fairly normal operation.
Alex
next prev parent reply other threads:[~2009-12-15 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 5:29 [PATCH] KVM: VMX: Trap and invalid MWAIT/MONITOR instruction Sheng Yang
2009-12-15 7:36 ` Alexander Graf
2009-12-15 9:23 ` Avi Kivity
2009-12-15 9:36 ` Alexander Graf [this message]
2009-12-15 9:52 ` Avi Kivity
2009-12-15 9:20 ` Avi Kivity
2009-12-15 9:26 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2009-12-15 4:45 Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2758B5.3040105@suse.de \
--to=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.