From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Make S390x work in qemu-kvm
Date: Tue, 15 Dec 2009 15:07:49 +0200 [thread overview]
Message-ID: <4B278A25.8050103@redhat.com> (raw)
In-Reply-To: <4B27892A.2080907@suse.de>
On 12/15/2009 03:03 PM, Alexander Graf wrote:
>
>
>>>> Why isn't cpu_synchronize_state() suitable?
>>>>
>>>>
>>> Because the KVM fd's are not available yet.
>>>
>>>
>> Then kvm_arch_load_regs() will fail as well, no?
>>
> Eeeh - there was a reason this didn't fail :-). I don't remember.
>
Please find out.
>>> Because it collided with the init function provided by
>>> target-s390x/kvm.c.
>>>
>>>
>> I'd prefer a separate rename then.
>>
> Rename in kvm.c?
>
kvm.c is harder to coordinate (need to rename in upstream), so rename
the qemu-kvm specific function.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-12-15 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 15:35 [PATCH] Make S390x work in qemu-kvm Alexander Graf
2009-12-15 10:42 ` Avi Kivity
2009-12-15 11:13 ` Alexander Graf
2009-12-15 12:30 ` Avi Kivity
2009-12-15 13:03 ` Alexander Graf
2009-12-15 13:07 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B278A25.8050103@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.