From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Make S390x work in qemu-kvm Date: Tue, 15 Dec 2009 15:07:49 +0200 Message-ID: <4B278A25.8050103@redhat.com> References: <1260286554-18253-1-git-send-email-agraf@suse.de> <4B276804.9080605@redhat.com> <4B276F4A.805@suse.de> <4B278161.7080600@redhat.com> <4B27892A.2080907@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbZLONHz (ORCPT ); Tue, 15 Dec 2009 08:07:55 -0500 In-Reply-To: <4B27892A.2080907@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 12/15/2009 03:03 PM, Alexander Graf wrote: > > >>>> Why isn't cpu_synchronize_state() suitable? >>>> >>>> >>> Because the KVM fd's are not available yet. >>> >>> >> Then kvm_arch_load_regs() will fail as well, no? >> > Eeeh - there was a reason this didn't fail :-). I don't remember. > Please find out. >>> Because it collided with the init function provided by >>> target-s390x/kvm.c. >>> >>> >> I'd prefer a separate rename then. >> > Rename in kvm.c? > kvm.c is harder to coordinate (need to rename in upstream), so rename the qemu-kvm specific function. -- error compiling committee.c: too many arguments to function