From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Extend KVM_SET_VCPU_EVENTS with selective updates Date: Tue, 15 Dec 2009 16:54:39 +0200 Message-ID: <4B27A32F.7030302@redhat.com> References: <4B1BE216.2090407@web.de> <4B1BE452.6090107@redhat.com> <4B1BE60D.5070107@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm , Gleb Natapov To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25841 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759348AbZLOOyl (ORCPT ); Tue, 15 Dec 2009 09:54:41 -0500 In-Reply-To: <4B1BE60D.5070107@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 12/06/2009 07:12 PM, Jan Kiszka wrote: > Avi Kivity wrote: > >> On 12/06/2009 06:55 PM, Jan Kiszka wrote: >> >>> User space may not want to overwrite asynchronously changing VCPU event >>> states on write-back. So allow to skip nmi.pending and sipi_vector by >>> setting corresponding bits in the flags field of kvm_vcpu_events. >>> >>> >> I think a positive flag (do update nmi and sipi_vector) will cause less >> confusion, no? If we do that, we'll need to set them on >> KVM_GET_VCPU_EVENTS. >> > I'm fine with the former but I don't understand the latter. > > What I meant was the on KVM_GET_VCPU_EVENTS, the two flags should be set. This way, the meaning of the flags is identical on both: the associated field contains valid data. I made this change to your v2 and applied and queued for .33. Please review (in next) to make sure it makes sense. -- error compiling committee.c: too many arguments to function