From: mike@compulab.co.il (Mike Rapoport)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] pxa/cm-x300: fix build breakage caused by missing 'select CPU_PXA310'
Date: Tue, 15 Dec 2009 18:28:27 +0200 [thread overview]
Message-ID: <4B27B92B.9020306@compulab.co.il> (raw)
Eric,
Apparently Igor's patches for CM-X300 were not applied properly. Somehow
commit db205463fd24c0972ad2c4e4fafb1c76e51b4380
([ARM] pxa/cm-x300: add PWM backlight support) introduced 'select HAVE_PWM'
to MACH_COLIBRY300 rather than CM-X300. I suspect that the same happened with
the patch that added 'select CPU_PXA310' to MACH_CM_X300. I'm not certain about
removing PWM support in Colibri, but MACH_CM_X300 need to get fixed.
---
Build of cm_x300_defconfig produces a bunch of errors:
CC arch/arm/mach-pxa/cm-x300.o
arch/arm/mach-pxa/cm-x300.c:186: error: 'ULPI_STP' undeclared here (not in a function)
arch/arm/mach-pxa/cm-x300.c:187: error: 'ULPI_NXT' undeclared here (not in a function)
arch/arm/mach-pxa/cm-x300.c:188: error: 'ULPI_DIR' undeclared here (not in a function)
arch/arm/mach-pxa/cm-x300.c:196: error: 'GPIO37_ULPI_DATA_OUT_7' undeclared here (not in a function)
arch/arm/mach-pxa/cm-x300.c:197: error: 'GPIO38_ULPI_CLK' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-pxa/cm-x300.o] Error 1
make: *** [arch/arm/mach-pxa] Error 2
The missing defines are available when CONFIG_CPU_PXA310=y. Adding
'select CPU_PXA310' fixes the build
Signed-off-by: Mike Rapoport <mike@compulab.co.il>
---
arch/arm/mach-pxa/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
index e6d8e10..4668d4b 100644
--- a/arch/arm/mach-pxa/Kconfig
+++ b/arch/arm/mach-pxa/Kconfig
@@ -110,6 +110,8 @@ config MACH_CM_X300
bool "CompuLab CM-X300 modules"
select PXA3xx
select CPU_PXA300
+ select CPU_PXA310
+ select HAVE_PWM
config ARCH_GUMSTIX
bool "Gumstix XScale 255 boards"
--
1.6.0.6
--
Sincerely yours,
Mike.
next reply other threads:[~2009-12-15 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 16:28 Mike Rapoport [this message]
2009-12-15 17:23 ` [PATCH] [ARM] pxa/cm-x300: fix build breakage caused by missing 'select CPU_PXA310' Russell King - ARM Linux
2009-12-16 13:24 ` Mike Rapoport
2009-12-16 13:25 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B27B92B.9020306@compulab.co.il \
--to=mike@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.