From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: x86: Extend KVM_SET_VCPU_EVENTS with selective updates Date: Tue, 15 Dec 2009 17:41:57 +0100 Message-ID: <4B27BC55.4070606@web.de> References: <4B1BE216.2090407@web.de> <4B1BE452.6090107@redhat.com> <4B1BE60D.5070107@web.de> <4B27A32F.7030302@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig21EB051D9DA8B4BEF600E203" Cc: Marcelo Tosatti , kvm , Gleb Natapov To: Avi Kivity Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:53712 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853AbZLOQmi (ORCPT ); Tue, 15 Dec 2009 11:42:38 -0500 In-Reply-To: <4B27A32F.7030302@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig21EB051D9DA8B4BEF600E203 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 12/06/2009 07:12 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> =20 >>> On 12/06/2009 06:55 PM, Jan Kiszka wrote: >>> =20 >>>> User space may not want to overwrite asynchronously changing VCPU ev= ent >>>> states on write-back. So allow to skip nmi.pending and sipi_vector b= y >>>> setting corresponding bits in the flags field of kvm_vcpu_events. >>>> >>>> =20 >>> I think a positive flag (do update nmi and sipi_vector) will cause le= ss >>> confusion, no? If we do that, we'll need to set them on >>> KVM_GET_VCPU_EVENTS. >>> =20 >> I'm fine with the former but I don't understand the latter. >> >> =20 >=20 > What I meant was the on KVM_GET_VCPU_EVENTS, the two flags should be > set. This way, the meaning of the flags is identical on both: the > associated field contains valid data. >=20 > I made this change to your v2 and applied and queued for .33. Please > review (in next) to make sure it makes sense. >=20 OK, but calling these bits "SET" makes no sense anymore. What about KVM_VCPUEVENT_VALID_*? Jan --------------enig21EB051D9DA8B4BEF600E203 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAksnvHoACgkQitSsb3rl5xTf4QCgvszbqHFdVJpd44YSpF+ITQKx EhkAn2MF2ruxSCbNCQ2NhpqMIE2ujn/d =FQgd -----END PGP SIGNATURE----- --------------enig21EB051D9DA8B4BEF600E203--