From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: is_xen_swiotlb_buffer() vs CONFIG_HIGHMEM
Date: Tue, 15 Dec 2009 10:34:01 -0800 [thread overview]
Message-ID: <4B27D699.5080901@goop.org> (raw)
In-Reply-To: <4B2661970200007800025B69@vpn.id2.novell.com>
On 12/14/2009 07:02 AM, Jan Beulich wrote:
> shouldn't is_xen_swiotlb_buffer() also check against e.g. highstart_pfn
> to deal with wrap-around potentially leading to aliasing of
> [xen_io_tlb_start,xen_io_tlb_end)?
>
So what you're saying is that if the pfn is for a high page, then
"__va(pfn << PAGE_SHIFT);" is simply invalid. The resulting addr is
undefined, and may end up erroneously aliasing with the xen tlb buffer.
Do I understand your concern properly?
J
next prev parent reply other threads:[~2009-12-15 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 15:02 is_xen_swiotlb_buffer() vs CONFIG_HIGHMEM Jan Beulich
2009-12-15 18:34 ` Jeremy Fitzhardinge [this message]
2009-12-16 7:40 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B27D699.5080901@goop.org \
--to=jeremy@goop.org \
--cc=JBeulich@novell.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.