From: Alexander Graf <agraf@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm list <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
Muli Ben-Yehuda <muli@il.ibm.com>,
Chris Wright <chrisw@redhat.com>
Subject: Re: [PATCH 2/3] Split off sysfs id retrieval
Date: Tue, 15 Dec 2009 19:54:41 +0100 [thread overview]
Message-ID: <4B27DB71.8000907@suse.de> (raw)
In-Reply-To: <20091215183940.GB25724@redhat.com>
Michael S. Tsirkin wrote:
> On Tue, Dec 15, 2009 at 07:30:27PM +0100, Alexander Graf wrote:
>
>> To retreive device and vendor ID from a PCI device, we need to read a
>> sysfs file. That code is currently hand written at least two times,
>> the later patch introducing two more calls.
>>
>> So let's move that out to a function.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>
>
> Shouldn't we be using libpci, as we already do
> in other places?
>
Yes, please! But converting it to libvirt is a different beast from just
splitting up existing code :-).
Tackling the device assignment code to make it readable and mergable is
definitely something we need to address - just not now :-).
Alex
next prev parent reply other threads:[~2009-12-15 18:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 18:30 [PATCH 0/3] Device Assignment fixes Alexander Graf
2009-12-15 18:30 ` [PATCH 1/3] Enable non page boundary BAR device assignment Alexander Graf
2009-12-15 18:38 ` Michael S. Tsirkin
2009-12-15 18:47 ` Alexander Graf
2009-12-15 18:50 ` Michael S. Tsirkin
2009-12-15 19:04 ` Alexander Graf
2009-12-15 19:50 ` Chris Wright
2009-12-15 21:12 ` Michael S. Tsirkin
2009-12-16 5:44 ` Chris Wright
2009-12-15 21:04 ` Michael S. Tsirkin
2009-12-15 21:11 ` Alexander Graf
2009-12-16 5:47 ` Chris Wright
2009-12-16 10:41 ` Michael S. Tsirkin
2009-12-15 18:30 ` [PATCH 2/3] Split off sysfs id retrieval Alexander Graf
2009-12-15 18:39 ` Michael S. Tsirkin
2009-12-15 18:54 ` Alexander Graf [this message]
2009-12-15 21:05 ` Michael S. Tsirkin
2009-12-15 19:57 ` Chris Wright
2009-12-15 18:30 ` [PATCH 3/3] Inform users about busy device assignment attempt Alexander Graf
2009-12-15 18:41 ` Michael S. Tsirkin
2009-12-15 20:28 ` Chris Wright
2009-12-15 21:09 ` Michael S. Tsirkin
2009-12-15 21:10 ` Alexander Graf
2009-12-15 23:13 ` Chris Wright
-- strict thread matches above, loose matches on Subject: below --
2009-12-17 15:04 [PATCH 0/3] Device Assignment fixes Alexander Graf
2009-12-17 15:04 ` [PATCH 2/3] Split off sysfs id retrieval Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B27DB71.8000907@suse.de \
--to=agraf@suse.de \
--cc=chrisw@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.