From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 1/8 v3] cld: Declare common.c functions in common.h
Date: Tue, 15 Dec 2009 16:44:18 -0500
Message-ID: <4B280332.5060800@garzik.org>
References: <1260837177-3348-1-git-send-email-cmccabe@alumni.cmu.edu> <1260837177-3348-2-git-send-email-cmccabe@alumni.cmu.edu>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=q+rzn/k7Sr2CABl09+JFNIJ46PK3BLSmyYOc+f9lU/Q=;
        b=TICo+9HNiNnY8/yrlIMVkeL/5iqjFc8UuHR8KedlObVRalgExE+50lWzJmCSyHZX8f
         1vC6W5jgMkEw0uyA18q0KVVZ5BSCaBGoQLZ+RR8Ewq3qglQupgBFC3uiAiKHZIsBAPHL
         w/TUSrF3amQPKaS98We1D+VWsJh0M7f9THBKw=
In-Reply-To: <1260837177-3348-2-git-send-email-cmccabe@alumni.cmu.edu>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: Project Hail List <hail-devel@vger.kernel.org>, Pete Zaitcev <zaitcev@redhat.com>

On 12/14/2009 07:32 PM, Colin McCabe wrote:
> Signed-off-by: Colin McCabe<cmccabe@alumni.cmu.edu>

applied, after fixing two problems:

* did not survive 'make distcheck'.  common.h was needed in 
include/Makefile.am.
* introduced build warnings in the server.  added #include in server/cld.h.

Each patch should be internally consistent, and needs to survive 'make 
distcheck' and not introduce new build warnings (or errors!).

I also renamed common.h to cld_common.h, but that is a matter of taste, 
not a problem with your patch :)