From: Roel Kluin <roel.kluin@gmail.com>
To: Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] OneNAND: Fix test of unsigned in onenand_otp_walk()
Date: Wed, 16 Dec 2009 01:37:17 +0100 [thread overview]
Message-ID: <4B282BBD.4050106@gmail.com> (raw)
mtd->writesize and len are unsigned so the test does not work.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
you can test this with:
#include <stdio.h>
int main()
{
int c = 1, d = 1;
unsigned a = 30;
unsigned b = 10;
if ((b * c) - (d + a) < 0)
printf("good\n");
else
printf("bad\n");
return 0;
}
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index ff66e43..cbe2711 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -2725,7 +2725,7 @@ static int onenand_otp_walk(struct mtd_info *mtd, loff_t from, size_t len,
}
/* Check User/Factory boundary */
- if (((mtd->writesize * otp_pages) - (from + len)) < 0)
+ if (mtd->writesize * otp_pages < from + len)
return 0;
onenand_get_device(mtd, FL_OTPING);
next reply other threads:[~2009-12-16 0:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 0:37 Roel Kluin [this message]
2009-12-16 1:20 ` [PATCH] OneNAND: Fix test of unsigned in onenand_otp_walk() Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B282BBD.4050106@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.