Re: [PATCH 2/9] pci: add pci_bridge_release_unused_res and pci_bus_release_unused_bridge_res

[Yinghai Lu <yinghai@kernel.org>]

Jesse Barnes wrote:
> On Fri, 27 Nov 2009 23:35:14 -0800
> Yinghai Lu <yinghai@kernel.org> wrote:
> 
>> so later we could use it to release small resource before pci assign
>> unassign res
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>>
>> ---
>>  drivers/pci/setup-bus.c |  114
>> +++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 113
>> insertions(+), 1 deletion(-)
>>
>> Index: linux-2.6/drivers/pci/setup-bus.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/pci/setup-bus.c
>> +++ linux-2.6/drivers/pci/setup-bus.c
>> @@ -609,6 +609,118 @@ void __ref pci_bus_assign_resources(cons
>>  }
>>  EXPORT_SYMBOL(pci_bus_assign_resources);
>>  
>> +static void release_children_resource(struct resource *r)
> 
> release_child_resources?

ok

> 
>> +{
>> +	struct resource *p;
>> +	resource_size_t size;
>> +
>> +	p = r->child;
>> +	while (p) {
>> +		release_children_resource(p);
>> +		release_resource(p);
>> +		printk(KERN_DEBUG "PCI: release child resource
>> %pRt\n", p);
>> +		/* need to restore size, and keep flags */
>> +		size = resource_size(p);
>> +		p->start = 0;
>> +		p->end = size - 1;
>> +		p = r->child;
>> +	}
>> +}
> 
> Also seems like it should go into resource.c instead?

only one user, may move that later...

YH