From: "H. Peter Anvin" <hpa@zytor.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Roland Dreier <rdreier@cisco.com>,
Andrew Isaacson <adi@vmware.com>, Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, Rob Landley <rob@landley.net>
Subject: Re: CONFIG_KPROBES=y build requires gawk
Date: Wed, 16 Dec 2009 19:45:01 -0800 [thread overview]
Message-ID: <4B29A93D.40207@zytor.com> (raw)
In-Reply-To: <4B29A686.9070603@redhat.com>
On 12/16/2009 07:33 PM, Masami Hiramatsu wrote:
> Roland Dreier wrote:
>> Is there any reason not to apply the patch below, to allow more awk
>> implementations to be used? After all, it's not like we're going to put
>> non-ASCII characters into the map file...
>
> Actually, the reason why I decided to use character classes is
> [a-z] wasn't same as [[:lower:]] on some environment.
>
> For example, before the POSIX standard, to match alphanumeric charac-
> ters, you would have had to write /[A-Za-z0-9]/. If your character set
> had other alphabetic characters in it, this would not match them, and
> if your character set collated differently from ASCII, this might not
> even match the ASCII alphanumeric characters. With the POSIX character
> classes, you can write /[[:alnum:]]/, and this matches the alphabetic
> and numeric characters in your character set, no matter what it is.
>
> It seems that "your character set" doesn't mean "what character set are used
> in the data", it means "what character set build env. is using".
>
> So, actually, my first released script had used [a-z], but I needed to
> move onto [[:lower:]].
>
This is correct if you are not in the C locale, but I'm not sure if we
support building the kernel in a non-C locale in the first place.
Do you have a known failure case? There is also the option of
explicitly setting LC_CTYPE=C. Sigh.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-12-17 3:52 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 23:56 CONFIG_KPROBES=y build requires gawk Andrew Isaacson
2009-12-17 1:19 ` Al Viro
2009-12-17 3:43 ` Masami Hiramatsu
2009-12-17 4:30 ` Al Viro
2009-12-17 5:16 ` Masami Hiramatsu
2009-12-17 1:39 ` Roland Dreier
2009-12-17 2:43 ` H. Peter Anvin
2009-12-17 3:02 ` Al Viro
2009-12-17 4:09 ` Roland Dreier
2009-12-17 5:07 ` H. Peter Anvin
2009-12-17 5:21 ` Masami Hiramatsu
2009-12-17 5:22 ` H. Peter Anvin
2009-12-17 4:09 ` Rob Landley
2009-12-17 3:33 ` Masami Hiramatsu
2009-12-17 3:45 ` H. Peter Anvin [this message]
2009-12-17 4:12 ` Rob Landley
2009-12-17 4:15 ` Roland Dreier
2009-12-17 4:56 ` Masami Hiramatsu
2009-12-17 5:11 ` Roland Dreier
2009-12-17 5:21 ` H. Peter Anvin
2009-12-17 5:43 ` Rob Landley
2009-12-17 5:49 ` Masami Hiramatsu
2009-12-17 5:49 ` H. Peter Anvin
2009-12-17 6:06 ` Masami Hiramatsu
2009-12-17 6:08 ` H. Peter Anvin
2009-12-17 6:20 ` Masami Hiramatsu
2009-12-17 6:26 ` H. Peter Anvin
2009-12-17 6:51 ` Roland Dreier
2009-12-17 13:18 ` Masami Hiramatsu
2009-12-17 5:45 ` Sam Ravnborg
2009-12-17 5:56 ` H. Peter Anvin
2009-12-17 6:17 ` Roland Dreier
2009-12-17 6:23 ` H. Peter Anvin
2009-12-17 7:54 ` Sam Ravnborg
2009-12-17 8:09 ` Sam Ravnborg
2009-12-17 11:34 ` Michal Marek
2009-12-17 16:18 ` [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C tip-bot for H. Peter Anvin
2009-12-17 22:09 ` Sam Ravnborg
2009-12-17 22:28 ` H. Peter Anvin
2009-12-17 23:34 ` Masami Hiramatsu
2009-12-17 23:37 ` H. Peter Anvin
2009-12-17 23:41 ` H. Peter Anvin
2009-12-17 23:41 ` Masami Hiramatsu
2009-12-17 23:45 ` H. Peter Anvin
2009-12-17 23:49 ` Masami Hiramatsu
2009-12-17 23:58 ` [tip:x86/urgent] Makefile: Unexport LC_ALL instead of clearing it tip-bot for H. Peter Anvin
2009-12-17 23:40 ` [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C Roland Dreier
2009-12-17 23:44 ` Masami Hiramatsu
2009-12-17 23:46 ` H. Peter Anvin
2009-12-17 23:54 ` Masami Hiramatsu
2009-12-17 14:50 ` CONFIG_KPROBES=y build requires gawk H. Peter Anvin
2009-12-17 10:42 ` Michal Marek
2009-12-17 13:21 ` Masami Hiramatsu
2009-12-17 16:18 ` [tip:x86/urgent] x86: Don't use POSIX character classes in gen-insn-attr-x86.awk tip-bot for Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B29A93D.40207@zytor.com \
--to=hpa@zytor.com \
--cc=adi@vmware.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@redhat.com \
--cc=rdreier@cisco.com \
--cc=rob@landley.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.