From: Jeff Garzik <jgarzik@pobox.com>
To: Alexander Strakh <strakh@ispras.ru>
Cc: Mark Lord <mlord@pobox.com>,
linux-ide@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: BUG null dereference in drivers/ata/sata_mv.c
Date: Thu, 17 Dec 2009 01:25:10 -0500 [thread overview]
Message-ID: <4B29CEC6.5010705@pobox.com> (raw)
In-Reply-To: <200912142051.34029.strakh@ispras.ru>
On 12/14/2009 03:51 PM, Alexander Strakh wrote:
> KERNEL_VERSION: 2.6.32
> SUBJECT: null dereference in function mv_unexpected_intr
> DESCRIBE:
> In ./drivers/ata/sata_mv.c in function mv_port_intr
>
> 1. If ap == NULL in line 2778, then we goto line 2779.
> 2. In line 2779 function mv_unexpected_intr(ap, 0) is called.
> 3. In line 2538 null dereference: "ap->link.eh_info"
>
> 2773 static void mv_port_intr(struct ata_port *ap, u32 port_cause)
> 2774 {
> ...
> 2778 if (!ap || (ap->flags& ATA_FLAG_DISABLED)) {
> 2779 mv_unexpected_intr(ap, 0);
> 2780 return;
pointless null test removed...
prev parent reply other threads:[~2009-12-17 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 20:51 BUG null dereference in drivers/ata/sata_mv.c Alexander Strakh
2009-12-15 1:34 ` Robert Hancock
2009-12-17 6:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B29CEC6.5010705@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=strakh@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.