From: Wolfgang Grandegger <wg@grandegger.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, "David Vrabel" <dvrabel@arcom.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Urs Thuermann" <urs.thuermann@volkswagen.de>,
"Oliver Hartkopp" <oliver.hartkopp@volkswagen.de>,
"David S. Miller" <davem@davemloft.net>,
"Kurt Van Dijck" <kurt.van.dijck@eia.be>,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/7] can/at91: don't check platform_get_irq's return value against zero
Date: Thu, 17 Dec 2009 08:17:31 +0100 [thread overview]
Message-ID: <4B29DB0B.1060109@grandegger.com> (raw)
In-Reply-To: <20091216174749.277761fe@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> + if (!res || irq <= (int)NO_IRQ) {
>>
>> but this looks too ugly. (IMHO using NO_IRQ is already ugly.)
>
> No IRQ was a private variable for the drivers/ide stack internally and
> only present in any form on a few odd platforms where it got "borrowed"
> and hasn't yet been eliminated
>
> The absence of an IRQ is zero. A bus IRQ of zero is remapped by the OS.
OK, I was remembering some old issues with NO_IRQ. Next time I will read
the commit message more carefully. Sorry for the noise.
Wolfgang.
next prev parent reply other threads:[~2009-12-17 7:18 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 16:10 [PATCH 1/7] [AVR32] don't check platform_get_irq's return value against zero Uwe Kleine-König
2009-12-16 16:10 ` [PATCH 2/7] V4L/DVB mx1_camera: " Uwe Kleine-König
2009-12-16 16:10 ` [PATCH 3/7] V4L/DVB sh_mobile_ceu: " Uwe Kleine-König
2009-12-16 16:10 ` [PATCH 4/7] can/at91: " Uwe Kleine-König
2009-12-16 16:10 ` [PATCH 5/7] pcmcia/bfin_cf: " Uwe Kleine-König
2009-12-16 16:10 ` [PATCH 6/7] spi/mpc8xxx: " Uwe Kleine-König
2009-12-16 16:10 ` [PATCH 7/7] ASoC: sh: FSI:: " Uwe Kleine-König
2009-12-17 1:42 ` Kuninori Morimoto
2009-12-17 1:42 ` Kuninori Morimoto
2009-12-17 9:47 ` Uwe Kleine-König
2009-12-22 12:34 ` Mark Brown
2009-12-22 12:34 ` Mark Brown
2009-12-16 16:32 ` [PATCH 6/7] spi/mpc8xxx: " Anton Vorontsov
2009-12-16 17:49 ` Uwe Kleine-König
2009-12-16 18:20 ` Anton Vorontsov
2009-12-16 19:18 ` Uwe Kleine-König
2009-12-16 19:37 ` Anton Vorontsov
2009-12-16 19:51 ` Anton Vorontsov
2009-12-17 13:05 ` Uwe Kleine-König
2009-12-17 16:25 ` Anton Vorontsov
2009-12-16 18:20 ` David Vrabel
2009-12-17 16:39 ` Anton Vorontsov
2009-12-19 15:13 ` [PATCH] " Uwe Kleine-König
2009-12-16 16:27 ` [PATCH 4/7] can/at91: " Wolfgang Grandegger
2009-12-16 17:08 ` Uwe Kleine-König
2009-12-16 17:47 ` Alan Cox
2009-12-17 7:17 ` Wolfgang Grandegger [this message]
2009-12-16 18:57 ` Wolfgang Grandegger
2009-12-16 18:58 ` Wolfgang Grandegger
2009-12-19 4:32 ` David Miller
2010-01-13 11:05 ` [RESEND PATCH 1/5] [AVR32] " Uwe Kleine-König
2010-01-13 11:05 ` [RESEND PATCH 2/5] V4L/DVB mx1_camera: " Uwe Kleine-König
2010-01-13 11:57 ` platform_get_irq() v4l fixes Guennadi Liakhovetski
2010-01-13 11:05 ` [RESEND PATCH 3/5] V4L/DVB sh_mobile_ceu: don't check platform_get_irq's return value against zero Uwe Kleine-König
2010-01-13 11:05 ` [RESEND PATCH 4/5] pcmcia/bfin_cf: " Uwe Kleine-König
2010-01-13 11:05 ` [RESEND PATCH 5/5] spi/mpc8xxx: " Uwe Kleine-König
2010-01-13 11:17 ` Anton Vorontsov
2010-10-19 6:45 ` [PATCH 1/7] [AVR32] " Uwe Kleine-König
2010-11-01 9:58 ` Hans-Christian Egtvedt
2010-11-02 9:15 ` Uwe Kleine-König
2010-11-02 9:30 ` Hans-Christian Egtvedt
2011-02-09 10:28 ` [PATCH RESENT#2] " Uwe Kleine-König
2011-02-09 10:43 ` Alan Cox
2011-02-09 12:28 ` Hans-Christian Egtvedt
2011-02-09 12:44 ` Uwe Kleine-König
2011-02-09 12:51 ` Hans-Christian Egtvedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B29DB0B.1060109@grandegger.com \
--to=wg@grandegger.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=dvrabel@arcom.com \
--cc=gregkh@suse.de \
--cc=kurt.van.dijck@eia.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.