From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Nested VMX support v4 Date: Thu, 17 Dec 2009 15:49:04 +0200 Message-ID: <4B2A36D0.8050004@redhat.com> References: <1260470309-7166-1-git-send-email-oritw@il.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, benami@il.ibm.com, abelg@il.ibm.com, muli@il.ibm.com, aliguori@us.ibm.com, mdday@us.ibm.com To: oritw@il.ibm.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935705AbZLQNtJ (ORCPT ); Thu, 17 Dec 2009 08:49:09 -0500 In-Reply-To: <1260470309-7166-1-git-send-email-oritw@il.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/10/2009 08:38 PM, oritw@il.ibm.com wrote: > Avi, > We have addressed all of the comments, please apply. > > I'm afraid there is still a lot of work remaining. > This work was inspired by the nested SVM support by Alexander Graf and Joerg > Roedel. > > Please try to make this as readable as the svm work. That means smaller patches, detailed changelogs, reduced forward declarations. I would appreciate documentation of the data structures. I am still confused about the triplication in kvm_vcpu, l1_state, and l2_state - there shouldn't be three, just two. -- error compiling committee.c: too many arguments to function