From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Colp Subject: Re: [PATCH] Paging and memory sharing for HVM guests Date: Thu, 17 Dec 2009 09:02:37 -0800 Message-ID: <4B2A642D.3040501@cs.ubc.ca> References: <20091217163845.GA26398@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091217163845.GA26398@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com, Keir Fraser , Grzegorz Milos , Andrew Peace List-Id: xen-devel@lists.xenproject.org > 1). mem_event_xen_core.patch > > "Copyright (c) 2009 Citrix (R)&D) Ltd. (Patrick Colp)" > > The lawyers might not like it the copyright being assigned to a non-existent > entity :-( Oops. That should be easy enough to fix. > 2). mem_paging_xen_pfec_page_paged.patch: > > 15 + if ( p2m_is_paging(p2mt) ) > 16 + { > 17 +// if ( p2m_is_paged(p2mt) ) > > I think you can safely remove the commented out code. Yes we can. I thought I had removed all of the lines like that. > 3). mem_sharing_xen_mm.patch: > > 27 + /* > 28 + * Initialise our DOMID_IO domain. > ^^->COW > 29 + * This domain owns sharable pages. > 30 + */ > 31 + dom_cow = domain_create(DOMID_COW, DOMCRF_dummy, 0); > > > 4), mem_sharing_tools_eagain.patch > > The code spins with a 1 second timeout forever. Would it make sense > to include a retry counter so that, say after an hour (or maybe something > much smaller) you give up? I'll defer these to Grzegorz. Patrick