From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Colp Subject: Re: [PATCH] Paging and memory sharing for HVM guests Date: Thu, 17 Dec 2009 09:05:47 -0800 Message-ID: <4B2A64EB.3010004@cs.ubc.ca> References: <20091217163845.GA26398@phenom.dumpdata.com> <4B2A719E020000780002679C@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B2A719E020000780002679C@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: Keir Fraser , xen-devel@lists.xensource.com, Andrew Peace , Grzegorz Milos , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: >>>> Konrad Rzeszutek Wilk 17.12.09 17:38 >>> >> 1). The "*mfnp |= 0x80000000U;" and "*mfnp |= 0xf0000000U;" should >> use a #define. Maybe copy over the #defines from the xen tree ? > > Did you find any defines in the tools sources for that? The only place I > found this condition being checked at all was in xc_map_foreign_pages(), > where it used hard-coded values. Or are you referring to the > XEN_DOMCTL_PFINFO_* values? I'd say they're being mis-used when > applied to the mfn array used by mmap-batch (including apparent > pre-existing uses). I think many people agree that this idea of using 0xf0000000 is a very inelegant solution (myself included). Maybe now would be a good time to hash out what the proper way to deal with this is. I think this discussion should extend to the privcmd/libxc mmap interfaces generally as well. Patrick