From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] Paging and memory sharing for HVM guests Date: Thu, 17 Dec 2009 12:15:52 -0800 Message-ID: <4B2A9178.2000404@goop.org> References: <4B2A8AC0.1080902@goop.org> <4B2A8FBE.4090000@cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4B2A8FBE.4090000@cs.ubc.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Patrick Colp Cc: xen-devel@lists.xensource.com, Keir Fraser , Grzegorz Milos , Andrew Peace List-Id: xen-devel@lists.xenproject.org On 12/17/2009 12:08 PM, Patrick Colp wrote: > That's odd. I just pulled a fresh copy of xen-unstable and built xen=20 > and the tools. Both compiled with no errors or problems. Maybe this is=20 > some sort of distro-dependent problem? Possibly. I'm using Fedora 11 on this machine, and it also fails in=20 Fedora 12. For the sleep() prototype, is it possible your versions=20 headers are implicitly including unistd.h, or otherwise have a prototype=20 for it? And for the xen/mem_event.h problem, might you have that header=20 installed somewhere? J > > > Patrick > > > Jeremy Fitzhardinge wrote: >> On 12/16/2009 03:14 PM, Grzegorz Milos wrote: >>> The series of 46 patches attached to this email contain the initial >>> implementation of memory paging and sharing for Xen. Patrick Colp >>> leads the work on the pager, and I am mostly responsible for memory >>> sharing. We would be grateful for any comments/suggestions you might >>> have. Individual patches are labeled with comments describing their >>> purpose and a sign-off footnote. Of course we are happy to discuss >>> them in more detail, as required. Assuming that there are no major >>> objections against including them in the mainstream xen-unstable tree= , >>> we would like to move future development to that tree. >> >> I'm getting compile errors: >> >> gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g=20 >> -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes=20 >> -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD=20 >> -MF .bidir-daemon.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE =20 >> -Werror -Wno-unused -I../include -I../../tools/libxc=20 >> -I../../tools/include -D_GNU_SOURCE -fPIC -g=20 >> -Wp,-MD,.bidir-daemon.o.d -c -o bidir-daemon.o bidir-daemon.c >> cc1: warnings being treated as errors >> bidir-daemon.c: In function =91bidir_daemon=92: >> bidir-daemon.c:74: error: implicit declaration of function =91sleep=92 >> make[3]: *** [bidir-daemon.o] Error 1 >> make[3]: Leaving directory `/home/jeremy/hg/xen/unstable/tools/memshr' >> >> and >> >> make[3]: Entering directory=20 >> `/home/jeremy/hg/xen/unstable/tools/xenpaging' >> gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g=20 >> -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes=20 >> -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD=20 >> -MF .file_ops.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I=20 >> ../../tools/python/xen/lowlevel/xc -I ./ -I../../tools/libxc=20 >> -I../../tools/include -I../../tools/xenstore -I../../tools/include=20 >> -Werror -Wno-unused -g -Wp,-MD,.file_ops.o.d -c -o file_ops.o file_ops= .c >> gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g=20 >> -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes=20 >> -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD=20 >> -MF .xc.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I=20 >> ../../tools/python/xen/lowlevel/xc -I ./ -I../../tools/libxc=20 >> -I../../tools/include -I../../tools/xenstore -I../../tools/include=20 >> -Werror -Wno-unused -g -Wp,-MD,.xc.o.d -c -o xc.o xc.c >> In file included from xc.c:29: >> xc.h:29:27: error: xen/mem_event.h: No such file or directory >> make[3]: *** [xc.o] Error 1 >> make[3]: Leaving directory=20 >> `/home/jeremy/hg/xen/unstable/tools/xenpaging' >> >> >> The first is easily fixed by adding #include , but I=20 >> haven't looked into the second yet. >> >> Thanks, >> J >