From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick Colp <pjcolp@cs.ubc.ca>
Subject: Re: [PATCH] Paging and memory sharing for HVM guests
Date: Thu, 17 Dec 2009 12:22:27 -0800
Message-ID: <4B2A9303.1020102@cs.ubc.ca>
References: <db8ce2bd0912161514s7a162546gf7f5909db22e274c@mail.gmail.com>
	<4B2A8AC0.1080902@goop.org> <4B2A8FBE.4090000@cs.ubc.ca>
	<4B2A9178.2000404@goop.org> <4B2A91B0.5030908@goop.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------040608050001010103070108"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4B2A91B0.5030908@goop.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir.fraser@eu.citrix.com>, Grzegorz Milos <gm281@cam.ac.uk>, Andrew Peace <Andrew.Peace@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------040608050001010103070108
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

OK. I've attached a patch to fix the include problem. I'll leave the 
xen/mem_event.h problem for now unless other people have it too.


Patrick


Jeremy Fitzhardinge wrote:
> On 12/17/2009 12:15 PM, Jeremy Fitzhardinge wrote:
>> On 12/17/2009 12:08 PM, Patrick Colp wrote:
>>> That's odd. I just pulled a fresh copy of xen-unstable and built xen 
>>> and the tools. Both compiled with no errors or problems. Maybe this 
>>> is some sort of distro-dependent problem?
>>
>> Possibly.  I'm using Fedora 11 on this machine, and it also fails in 
>> Fedora 12.  For the sleep() prototype, is it possible your versions 
>> headers are implicitly including unistd.h, or otherwise have a 
>> prototype for it?
>>
>> And for the xen/mem_event.h problem, might you have that header 
>> installed somewhere?
> 
> Though I just did a clean+build and it found the header, so maybe it was 
> something in the header symlink mess.
> 
> So just the sleep prototype problem.
> 
>     J

--------------040608050001010103070108
Content-Type: text/x-patch; name="mem_sharing_bidir_daemon_include_fix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
	filename="mem_sharing_bidir_daemon_include_fix.patch"

Add missing unistd.h header file which causes the build to fail on some
systems.

Signed-off-by: Patrick Colp <Patrick.Colp@citrix.com>

diff -r b47dfc7f5918 tools/memshr/bidir-daemon.c
--- a/tools/memshr/bidir-daemon.c	Thu Dec 17 09:21:56 2009 -0800
+++ b/tools/memshr/bidir-daemon.c	Thu Dec 17 12:19:57 2009 -0800
@@ -18,6 +18,7 @@
  */
 #include <pthread.h>
 #include <inttypes.h>
+#include <unistd.h>
 
 #include "bidir-hash.h"
 #include "memshr-priv.h"

--------------040608050001010103070108
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------040608050001010103070108--