All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: revert "config FS_JOURNAL_INFO"
Date: Fri, 18 Dec 2009 13:04:28 +0900	[thread overview]
Message-ID: <4B2AFF4C.5010100@ct.jp.nec.com> (raw)
In-Reply-To: <b6fcc0a0912170031u162b7f56kf9f6adc23e24278c@mail.gmail.com>

Alexey Dobriyan wrote:
> Can we please revert commit e4c570c4cb7a95dbfafa3d016d2739bf3fdfe319
> "task_struct: make journal_info conditional"

I'm fine to revert it, because it seems merged accidentally.

> 
> I think I gave a good enough arguments to not merge it.
> To iterate:
> * patch makes impossible to start using ext3 on EXT3_FS=n kernels
> without reboot.
> * this is done only for one pointer on task_struct

I don't think it's only one pointer.
There might be a lot of "only one pointer".

> 
> None of config options which define task_struct are tristate directly
> or effectively.

So we never allow to make memory usage small with providing an option
to remove unused area, right? Of cause, that option should be handled
carefully. If I want to reduce memory usage by this way, should I keep
this kind of patches out of tree?

thanks,
Hiroshi


  parent reply	other threads:[~2009-12-18  4:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-17  8:31 revert "config FS_JOURNAL_INFO" Alexey Dobriyan
2009-12-17 20:09 ` Andrew Morton
2009-12-18  4:04 ` Hiroshi Shimamoto [this message]
2009-12-18  7:25   ` Alexey Dobriyan
2009-12-18  7:48     ` Hiroshi Shimamoto
2009-12-19 11:51     ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2AFF4C.5010100@ct.jp.nec.com \
    --to=h-shimamoto@ct.jp.nec.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.