From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH] [pv-ops domU] support MAXSMP
Date: Fri, 18 Dec 2009 14:51:14 +0100
Message-ID: <4B2B88D2.5010405@redhat.com>
References: <4B2B4BF3.1010507@redhat.com>	<4B2B625D02000078000269B3@vpn.id2.novell.com>	<4B2B585D.5000305@redhat.com>
	<4B2B8234.50407@redhat.com>
	<4B2B94850200007800026A03@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4B2B94850200007800026A03@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 12/18/2009 02:41 PM, Jan Beulich wrote:
>>>> Andrew Jones<drjones@redhat.com>  18.12.09 14:23>>>
>> Another note here is that the amount of stack allocation is the same
>> regardless of the value of num_processors. We're just creating a pointer
>> to this structure on the stack. sizeof is smart enough to pass the
>> appropriate dynamic size on to the mc call for validation though. So I
>> think all should be good with this patch.
>
> Ah, okay. At least it'll be a clear BUG_ON() if an overflow happens. And
> that's probably what you got before your patch?
>

That's right; "kernel BUG at arch/x86/xen/multicalls.c:209!"

Andrew