All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading
Date: Fri, 18 Dec 2009 17:37:51 +0100	[thread overview]
Message-ID: <4B2BAFDF.50700@redhat.com> (raw)
In-Reply-To: <4B2BAC2D.4090605@codemonkey.ws>

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

On 12/18/09 17:22, Anthony Liguori wrote:
> I think your fw_cfg.h changes also broke the optionroms/multiboot build.
> Haven't debugged yet though.

That one is easy to fix, see attachment

cheers,
   Gerd

[-- Attachment #2: fix --]
[-- Type: text/plain, Size: 538 bytes --]

diff --git a/hw/fw_cfg.h b/hw/fw_cfg.h
index a63f54f..c1019d0 100644
--- a/hw/fw_cfg.h
+++ b/hw/fw_cfg.h
@@ -38,6 +38,7 @@
 
 #define FW_CFG_INVALID          0xffff
 
+#ifndef NO_QEMU_PROTOS
 typedef struct FWCfgFile {
     uint32_t  size;        /* file size */
     uint16_t  select;      /* write this to 0x510 to read it */
@@ -50,7 +51,6 @@ typedef struct FWCfgFiles {
     FWCfgFile f[];
 } FWCfgFiles;
 
-#ifndef NO_QEMU_PROTOS
 typedef void (*FWCfgCallback)(void *opaque, uint8_t *data);
 
 typedef struct _FWCfgState FWCfgState;

  reply	other threads:[~2009-12-18 16:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18 11:16 [Qemu-devel] [PATCH 0/4] qemu option loading Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 1/4] Do not guard qemu shadow ram work around in CONFIG_OPTIONROMS_DEPLOYED Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 2/4] Disable CONFIG_OPTIONROMS_DEPLOYED by default Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 3/4] move htonl() + friends to util.h Gerd Hoffmann
2009-12-18 11:16 ` [Qemu-devel] [PATCH 4/4] qemu: add rom loading via fw_cfg Gerd Hoffmann
2009-12-18 15:41 ` [Qemu-devel] Re: [SeaBIOS] [PATCH 0/4] qemu option loading Anthony Liguori
2009-12-18 15:52   ` Gerd Hoffmann
2009-12-18 16:22     ` Anthony Liguori
2009-12-18 16:37       ` Gerd Hoffmann [this message]
2009-12-18 23:40     ` Kevin O'Connor
2009-12-19  0:37 ` Kevin O'Connor
2009-12-19  2:55   ` Anthony Liguori
2009-12-19  3:37     ` Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2BAFDF.50700@redhat.com \
    --to=kraxel@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.