Re: [PATCH] Don't open same disk twice on OpenFirmware.

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Fri, 18 Dec 2009 10:33:13 -0800 (PST)
>
>   
>> From: Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>
>> Date: Fri, 18 Dec 2009 17:17:13 +0100
>>
>>     
>>> Hello, all. According to David Miller sparc's openboot doesn't support
>>> opening same disk twice. So I implemented handle reusage logic. Tested
>>> on imac g3
>>>       
>> At a minimum you have to seek to the beginning of the device
>> as that is one of the many side effects of openning the
>> device.
>>     
>
> In fact this proves that your idea can't ever work.
> Each openned instance will expect the file offset
> pointer to be at different locations.
>
> You can't share open instances, therefore.
>
> We really just have to make sure GRUB never violates
> this restriction.
>   
Actually we don't open files, only disks and we explicitely seek to
desired position. It was so even before my patch.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]