On 12/18/2009 03:37 AM, Laurent Desnogues wrote:
>>   tcg: Generic support for conditional set and conditional move.
>
> Needs cosmetics changes.

Fixed, attachment 1.

>>   tcg-x86_64: Implement setcond and movcond.
>
> Some cosmetics and comments, but overall good.

Fixed, attachment 2.

>>   tcg-i386: Implement small forward branches.
>
> I think this contains a bug.

Fixed, attachment 3.  I've added an abort to patch_reloc to verify that 
the relocation is in range.  I've propagated the "small" flag to all of 
the branch functions so that...

>>   tcg-i386: Simplify brcond2.
>
> I don't like the rewrite of brcond2.

... this patch is dropped.

>>   tcg-i386: Implement setcond, movcond, setcond2.
>
> Not yet reviewed.

Fixed, attachment 4.  Similar changes to the amd64 patch.


r~