From: Stephen Boyd <bebarino@gmail.com>
To: Eric Blake <ebb9@byu.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv2] am: fix patch format detection for Thunderbird "Save As" emails
Date: Fri, 18 Dec 2009 22:21:33 -0800 [thread overview]
Message-ID: <4B2C70ED.1020602@gmail.com> (raw)
In-Reply-To: <4B2C66D3.1070508@byu.net>
On 12/18/2009 09:38 PM, Eric Blake wrote:
> Closer, but not there yet. "$/" is still not defined. Then, as a matter
> of style, '\' is more readable than "\\" for representing a backslash. So
> as long as we are shifting to '', we might as well do it everywhere in
> that line - write it like this:
>
> } | sed -e 's/$/;/' | tr ';' '\015'> patch1-crlf.eml
>
> and you should be set.
Ah, I think you missed that this stuff is inside single quotes already.
I would love to just do what you suggest here.
I'm a little confused because I see this in a test (am
--committer-date-is-author-date) a ways down in the same file
git cat-file commit HEAD | sed -e "/^$/q">head1&&
and following your reasoning that wouldn't be portable?
Either way, I'll look for a better replacement character instead of
semi-colon.
next prev parent reply other threads:[~2009-12-19 6:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 23:58 [PATCH] am: fix patch format detection for Thunderbird "Save As" emails Stephen Boyd
2009-12-18 0:15 ` Junio C Hamano
2009-12-18 21:34 ` [PATCHv2] " Stephen Boyd
2009-12-18 21:42 ` Eric Blake
2009-12-18 21:59 ` Stephen Boyd
2009-12-18 22:42 ` Eric Blake
2009-12-19 2:24 ` Stephen Boyd
2009-12-19 5:38 ` Eric Blake
2009-12-19 6:21 ` Stephen Boyd [this message]
2009-12-19 7:07 ` Stephen Boyd
2009-12-19 7:39 ` Junio C Hamano
2009-12-19 11:49 ` Stephen Boyd
2009-12-19 10:26 ` Andreas Schwab
2009-12-18 23:49 ` Junio C Hamano
2010-01-05 22:38 ` Nanako Shiraishi
2010-01-21 18:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2C70ED.1020602@gmail.com \
--to=bebarino@gmail.com \
--cc=ebb9@byu.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.