From: Stefano Salsano <stefano.salsano@uniroma2.it>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, fabio.ludovici@yahoo.it,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH] netem/iproute2 solving correlated loss issues [0/5]
Date: Sat, 19 Dec 2009 10:45:32 +0100 [thread overview]
Message-ID: <4B2CA0BC.5080905@uniroma2.it> (raw)
In-Reply-To: <20091218.200406.183057577.davem@davemloft.net>
David Miller wrote:
>> The patch is backward compatible, we have not removed the previous...
>
> To heck it is!
> The changed version of iproute2 will not work without the kernel
> changes installed. The kernel validates the size of the structures
> passed in, you can't change the user visible interface like this.
David Miller wrote:
> Furthermore it is fundamentally flawed in it's implementation
> in that the user exported data structures cannot be changed,
> you cannot change the layout and you absolutely cannot
> change the size of these things or else various tool and
> kernel combinations stop working.
thank you for raising these fundamental issues !
we will address them and resubmit the patch when done...
> Add new netlink attributes to extend things, that's the "real"
> backwards compatible way to make changes to netlink interfaces.
point taken
--
*******************************************************************
Stefano Salsano
Dipartimento Ingegneria Elettronica
Universita' di Roma "Tor Vergata"
Via del Politecnico, 1 - 00133 Roma - ITALY
http://netgroup.uniroma2.it/Stefano_Salsano/
E-mail : stefano.salsano@uniroma2.it
Cell. : +39 320 4307310
Office : (Tel.) +39 06 72597770 (Fax.) +39 06 72597435
*******************************************************************
prev parent reply other threads:[~2009-12-19 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 10:39 [PATCH] netem/iproute2 solving correlated loss issues [0/5] Stefano Salsano
2009-12-18 11:22 ` Fabio Ludovici
2009-12-19 4:04 ` David Miller
2009-12-19 9:45 ` Stefano Salsano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2CA0BC.5080905@uniroma2.it \
--to=stefano.salsano@uniroma2.it \
--cc=davem@davemloft.net \
--cc=fabio.ludovici@yahoo.it \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.