All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Fruhwirth <clemens@endorphin.org>
To: linux-scsi@vger.kernel.org, grundler@google.com
Subject: Re: [PATCH] Forcing capacity sizes for block devices - (sorry, gmail ruined inlining with wordwrapping in the last mail)
Date: Sun, 20 Dec 2009 14:19:08 +0100	[thread overview]
Message-ID: <4B2E244C.8070705@endorphin.org> (raw)
In-Reply-To: <2f83750a0912200405v77f39a7eifef024cc4cb10a20@mail.gmail.com>

Make the size attribute of block devices writable via sysfs. This allows 
userspace to force
device boundaries in cases where the device driver is unable to detect 
the correct size, as
with spec-incompliant SD card readers.

diff -uprN -X linux-2.6.32-vanilla/Documentation/dontdiff 
linux-2.6.32-vanilla/block/genhd.c linux-2.6.32-patched/block/genhd.c
--- linux-2.6.32-vanilla/block/genhd.c    2009-12-03 04:51:21.000000000 
+0100
+++ linux-2.6.32-patched/block/genhd.c    2009-12-15 14:38:24.962463446 
+0100
@@ -865,7 +865,7 @@ static DEVICE_ATTR(range, S_IRUGO, disk_
  static DEVICE_ATTR(ext_range, S_IRUGO, disk_ext_range_show, NULL);
  static DEVICE_ATTR(removable, S_IRUGO, disk_removable_show, NULL);
  static DEVICE_ATTR(ro, S_IRUGO, disk_ro_show, NULL);
-static DEVICE_ATTR(size, S_IRUGO, part_size_show, NULL);
+static DEVICE_ATTR(size, S_IRUGO | S_IWUSR, part_size_show, 
part_size_set);
  static DEVICE_ATTR(alignment_offset, S_IRUGO, 
disk_alignment_offset_show, NULL);
  static DEVICE_ATTR(capability, S_IRUGO, disk_capability_show, NULL);
  static DEVICE_ATTR(stat, S_IRUGO, part_stat_show, NULL);
diff -uprN -X linux-2.6.32-vanilla/Documentation/dontdiff 
linux-2.6.32-vanilla/fs/partitions/check.c 
linux-2.6.32-patched/fs/partitions/check.c
--- linux-2.6.32-vanilla/fs/partitions/check.c    2009-12-03 
04:51:21.000000000 +0100
+++ linux-2.6.32-patched/fs/partitions/check.c    2009-12-19 
10:38:58.745294907 +0100
@@ -219,6 +219,18 @@ ssize_t part_size_show(struct device *de
      return sprintf(buf, "%llu\n",(unsigned long long)p->nr_sects);
  }

+ssize_t part_size_set(struct device *dev,
+              struct device_attribute *attr, char *buf, size_t len)
+{
+    struct hd_struct *p = dev_to_part(dev);
+    unsigned long long val;
+    if (strict_strtoull(buf, 0, &val))
+        return -EINVAL;
+
+    p->nr_sects = val;
+    return len;
+}
+
  ssize_t part_alignment_offset_show(struct device *dev,
                     struct device_attribute *attr, char *buf)
  {
diff -uprN -X linux-2.6.32-vanilla/Documentation/dontdiff 
linux-2.6.32-vanilla/include/linux/genhd.h 
linux-2.6.32-patched/include/linux/genhd.h
--- linux-2.6.32-vanilla/include/linux/genhd.h    2009-12-03 
04:51:21.000000000 +0100
+++ linux-2.6.32-patched/include/linux/genhd.h    2009-12-19 
10:40:30.900871273 +0100
@@ -549,6 +549,9 @@ extern void blk_unregister_region(dev_t

  extern ssize_t part_size_show(struct device *dev,
                    struct device_attribute *attr, char *buf);
+extern ssize_t part_size_set(struct device *dev,
+                 struct device_attribute *attr, char *buf,
+                 size_t len);
  extern ssize_t part_stat_show(struct device *dev,
                    struct device_attribute *attr, char *buf);
  extern ssize_t part_inflight_show(struct device *dev,

Signed-off-by: Clemens Fruhwirth <clemens@endorphin.org>
Reviewed-by: Grant Grundler <grundler@google.com>

  reply	other threads:[~2009-12-20 13:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-20 12:05 [PATCH] Forcing capacity sizes for block devices Clemens Fruhwirth
2009-12-20 13:19 ` Clemens Fruhwirth [this message]
2009-12-20 17:43 ` Bartlomiej Zolnierkiewicz
2009-12-21 20:04   ` Grant Grundler
2009-12-21 21:59     ` Bartlomiej Zolnierkiewicz
2009-12-22 20:15       ` Grant Grundler
     [not found]       ` <2f83750a0912240503g3aa7bcbw876a164d0e350b27@mail.gmail.com>
2009-12-24 13:40         ` Clemens Fruhwirth
2010-01-25 14:49           ` Clemens Fruhwirth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2E244C.8070705@endorphin.org \
    --to=clemens@endorphin.org \
    --cc=grundler@google.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.