From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/7] Nested VMX patch 1 implements vmon and vmoff Date: Sun, 20 Dec 2009 16:23:38 +0200 Message-ID: <4B2E336A.802@redhat.com> References: <1260470309-7166-1-git-send-email-oritw@il.ibm.com> <1260470309-7166-2-git-send-email-oritw@il.ibm.com> <20091220142018.GI4490@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: oritw@il.ibm.com, kvm@vger.kernel.org, benami@il.ibm.com, abelg@il.ibm.com, muli@il.ibm.com, aliguori@us.ibm.com, mdday@us.ibm.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48636 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbZLTOXx (ORCPT ); Sun, 20 Dec 2009 09:23:53 -0500 In-Reply-To: <20091220142018.GI4490@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/20/2009 04:20 PM, Gleb Natapov wrote: > + >> + if (create_l1_state(vcpu)) { >> + printk(KERN_ERR "%s create_l1_state failed\n", __func__); >> + kvm_queue_exception(vcpu, UD_VECTOR); >> > Should we send UD exception if there is internal error? May be doing > VMfailinvalid would be more appropriate? Also this function doesn't handle > all errors (address alignment, version checking, register operand). > Host errors like -ENOMEM should propagate to the return code of ioctl(). -- error compiling committee.c: too many arguments to function