From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NMQAK-0001Jj-Jq
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 13:06:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NMQAH-0001Hr-1q
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 13:06:00 -0500
Received: from [199.232.76.173] (port=57902 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NMQAG-0001Hn-QQ
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 13:05:56 -0500
Received: from moutng.kundenserver.de ([212.227.126.187]:64173)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1NMQAG-00074o-5Q
	for qemu-devel@nongnu.org; Sun, 20 Dec 2009 13:05:56 -0500
Message-ID: <4B2E6782.20605@mail.berlios.de>
Date: Sun, 20 Dec 2009 19:05:54 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3] eepro100: Better documentation for
	temporary data
References: <4B2E46C8.2020002@mail.berlios.de>
	<1261324344-10642-1-git-send-email-weil@mail.berlios.de>
	<1261324344-10642-2-git-send-email-weil@mail.berlios.de>
	<4C604D4F-0C64-48C5-894E-450FE42304C7@web.de>
In-Reply-To: <4C604D4F-0C64-48C5-894E-450FE42304C7@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Andreas Färber schrieb:
> Hello,
>
> Am 20.12.2009 um 16:52 schrieb Stefan Weil:
>
>> Michael S. Tsirkin suggested more documentation for
>> two temporary status values. Well, here it is.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>> hw/eepro100.c |    7 ++++---
>> 1 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/eepro100.c b/hw/eepro100.c
>> index 5635f61..fb455a4 100644
>> --- a/hw/eepro100.c
>> +++ b/hw/eepro100.c
>> @@ -213,9 +213,10 @@ typedef struct {
>>     uint32_t ru_offset;         /* RU address offset */
>>     uint32_t statsaddr;         /* pointer to eepro100_stats_t */
>>
>> -    /* Temporary data. */
>> -    eepro100_tx_t tx;
>> -    uint32_t cb_address;
>
> Since you just introduced this in patch 1/3, please add the verbose
> documentation to the patch introducing these variables.
>
> Andreas

Hi Andreas,

in this special case I won't resend the patch.
It was already sent too often :-)

Regards
Stefan