All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] HDA: simplify Aspire 8930G verb array
@ 2009-12-20 21:51 Hector Martin
  2009-12-21 10:28 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Hector Martin @ 2009-12-20 21:51 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

This patch just simplifies the 8930G verb array a bit. Just use the
common ALC889 EAPD verb array to make things more consistent. The file
is already huge enough already.

-- 
Hector Martin (hector@marcansoft.com)
Public Key: http://www.marcansoft.com/marcan.asc


[-- Attachment #2: aspire-8930g-simplify-verbs.patch --]
[-- Type: text/plain, Size: 1049 bytes --]

Signed-off-by: Hector Martin <hector@marcansoft.com>

--- linux-2.6.32/sound/pci/hda/patch_realtek_orig.c	2009-12-20 19:31:08.940900751 +0100
+++ linux-2.6.32/sound/pci/hda/patch_realtek.c	2009-12-20 22:14:11.852025021 +0100
@@ -1665,9 +1670,6 @@
 /*  some bit here disables the other DACs. Init=0x4900 */
 	{0x20, AC_VERB_SET_COEF_INDEX, 0x08},
 	{0x20, AC_VERB_SET_PROC_COEF, 0x0000},
-/* Enable amplifiers */
-	{0x14, AC_VERB_SET_EAPD_BTLENABLE, 0x02},
-	{0x15, AC_VERB_SET_EAPD_BTLENABLE, 0x02},
 /* DMIC fix
  * This laptop has a stereo digital microphone. The mics are only 1cm apart
  * which makes the stereo useless. However, either the mic or the ALC889
@@ -9305,7 +9305,8 @@
 		.mixers = { alc889_acer_aspire_8930g_mixer,
 				alc883_chmode_mixer },
 		.init_verbs = { alc883_init_verbs, alc880_gpio1_init_verbs,
-				alc889_acer_aspire_8930g_verbs },
+				alc889_acer_aspire_8930g_verbs,
+				alc889_eapd_verbs},
 		.num_dacs = ARRAY_SIZE(alc883_dac_nids),
 		.dac_nids = alc883_dac_nids,
 		.num_adc_nids = ARRAY_SIZE(alc889_adc_nids),

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] HDA: simplify Aspire 8930G verb array
  2009-12-20 21:51 [PATCH] HDA: simplify Aspire 8930G verb array Hector Martin
@ 2009-12-21 10:28 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-12-21 10:28 UTC (permalink / raw)
  To: Hector Martin; +Cc: alsa-devel

At Sun, 20 Dec 2009 22:51:18 +0100,
Hector Martin wrote:
> 
> This patch just simplifies the 8930G verb array a bit. Just use the
> common ALC889 EAPD verb array to make things more consistent. The file
> is already huge enough already.

Applied.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-21 10:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-20 21:51 [PATCH] HDA: simplify Aspire 8930G verb array Hector Martin
2009-12-21 10:28 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.