From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch 1/1] Chunk: fix stored checksums
Date: Mon, 21 Dec 2009 00:57:29 -0500 [thread overview]
Message-ID: <4B2F0E49.9010106@garzik.org> (raw)
In-Reply-To: <20091220194501.4cd6ad6f@redhat.com>
On 12/20/2009 09:45 PM, Pete Zaitcev wrote:
> Existing code writes checksums of something other than the object data.
> Fix by summing the object data.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
> server/object.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This seems too obvious... Where is the trap?
applied... how embarrassing.
The C client definitely needs code to verify each checksum, too. The
protocol is designed such that each side can verify checksums at each
point in the process... but the implementations are clearly not at the
design goal.
Jeff
prev parent reply other threads:[~2009-12-21 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 2:45 [Patch 1/1] Chunk: fix stored checksums Pete Zaitcev
2009-12-21 5:57 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2F0E49.9010106@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.