From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch 1/1] Chunk: fix stored checksums
Date: Mon, 21 Dec 2009 00:57:29 -0500
Message-ID: <4B2F0E49.9010106@garzik.org>
References: <20091220194501.4cd6ad6f@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=nrW6EtQJjWc4DlZ2yXyrJfGmcdzKp/sDv9OtiTuQNpI=;
        b=YQ5AVXTmHIPoLf2s6xdsyLVcrXlnWV2zPf6wyKUI2GcEa6a9EstPPzW3SECjUB6AT/
         iwvwLshU5h4N0QiKt0dvAqnt1hq6x390vRamm9NheY8at7gzQmnAbZUqtK5Ym5DertMI
         Gmr8ZY82E7cr5YE11zZPxOAGX4UMi3M5qkUKU=
In-Reply-To: <20091220194501.4cd6ad6f@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 12/20/2009 09:45 PM, Pete Zaitcev wrote:
> Existing code writes checksums of something other than the object data.
> Fix by summing the object data.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
>   server/object.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> This seems too obvious... Where is the trap?

applied...  how embarrassing.

The C client definitely needs code to verify each checksum, too.  The 
protocol is designed such that each side can verify checksums at each 
point in the process...  but the implementations are clearly not at the 
design goal.

	Jeff