From: Romit Dasgupta <romit@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: kevin h <khilman@deeprootsystems.com>,
linux omap <linux-omap@vger.kernel.org>,
"K, Ambresh" <ambresh@ti.com>
Subject: Re: [PATCH 1/2] io: remove redundant params in omap2_init_common_hw
Date: Mon, 21 Dec 2009 12:37:47 +0530 [thread overview]
Message-ID: <4B2F1EC3.3060001@ti.com> (raw)
In-Reply-To: <1261228253-30283-2-git-send-email-nm@ti.com>
> - omap2_init_common_hw(NULL, NULL, NULL, NULL, NULL);
> + omap2_init_common_hw(NULL, NULL);
A call to a function with NULL parameters suggests that the function is doing
more than it should. I think omap2_init_common_hw and omap2_sdrc_init,
_omap2_init_reprogram_sdrc, gpmc init can be separated from
omap2_init_common_hw. If you are refactoring the code may be this should be
taken care as well.
next prev parent reply other threads:[~2009-12-21 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 13:10 [PATCH 0/2] omap:pm: cleanup omap3_[mpu|dsp|l3]_rate_table Nishanth Menon
2009-12-19 13:10 ` [PATCH 1/2] io: remove redundant params in omap2_init_common_hw Nishanth Menon
2009-12-19 13:10 ` [PATCH 2/2] omap3: pm: remove omap3_[mpu|dsp|l3]_rate_tables Nishanth Menon
2009-12-21 7:07 ` Romit Dasgupta [this message]
2009-12-22 17:08 ` [PATCH 1/2] io: remove redundant params in omap2_init_common_hw Kevin Hilman
2009-12-22 17:02 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2F1EC3.3060001@ti.com \
--to=romit@ti.com \
--cc=ambresh@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.