Re: possible code error at run_command.c

[Johannes Sixt <j.sixt@viscovery.net>]

Frank Li schrieb:
>> This is a commonly used idiom to avoid an (incorrect) compiler warning
>> about an uninitialized variable.
>>
>> Strictly speaking, I think that you are right by saying "means nothing"
>> because the use of the uninitialized variable invokes undefined behavior
>> (and for this reason, I dislike this construct), but in practice it will
>> not make a difference.
>>
> 
> This error is captured at MSVC environment by run time varible check.

Disable this check - it just takes away performance. :-)

(If you don't disable the check, then keep the required changes private.)

> I prefer change it to
> int failed_errno = errno;

You don't need to initialize the variable at all because it is always
initialized elsewhere before it is used. Perhaps MSVC is clever enough to
see it?

-- Hannes