All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nigel Kukard <nkukard@lbsd.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Update xfsprogs
Date: Mon, 21 Dec 2009 12:02:22 +0000	[thread overview]
Message-ID: <4B2F63CE.1000801@lbsd.net> (raw)
In-Reply-To: <87tyvkzoec.fsf@macbook.be.48ers.dk>


>>>>>> "Nigel" == Nigel Kukard <nkukard@lbsd.net> writes:
>>>>>>             
>  Nigel> Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
>  Nigel> ---
>  Nigel>  package/xfsprogs/Config.in      |   10 +++---
>  Nigel>  package/xfsprogs/xfsprogs.mk    |    9 ++---
>  Nigel>  package/xfsprogs/xfsprogs.patch |   59 ---------------------------------------
>  Nigel>  3 files changed, 9 insertions(+), 69 deletions(-)
>  Nigel>  delete mode 100644 package/xfsprogs/xfsprogs.patch
>
>  Nigel> diff --git a/package/xfsprogs/Config.in b/package/xfsprogs/Config.in
>  Nigel> index 2f462cb..77e4d61 100644
>  Nigel> --- a/package/xfsprogs/Config.in
>  Nigel> +++ b/package/xfsprogs/Config.in
>  Nigel> @@ -1,6 +1,9 @@
>   
>  Nigel> -comment "xfssprogs requires a toolchain with LARGEFILE support"
>  Nigel> -	depends on !BR2_LARGEFILE
>  Nigel> -
>
> I don't see any references to the e2fsprogs libuuid?
>   

I'll change it to be auto selected just like BR2_PACKAGE_E2FSPROGS is

>  Nigel> diff --git a/package/xfsprogs/xfsprogs.mk b/package/xfsprogs/xfsprogs.mk
>  Nigel> index 89db6c1..e87485e 100644
>  Nigel> --- a/package/xfsprogs/xfsprogs.mk
>  Nigel> +++ b/package/xfsprogs/xfsprogs.mk
>  Nigel>  	rm -rf $(TARGET_DIR)/usr/man $(TARGET_DIR)/usr/share/doc
>  Nigel>  	touch -c $(TARGET_DIR)/$(XFSPROGS_TARGET_BINARY)
>  
>  Nigel> -xfsprogs: e2fsprogs libtool-cross $(TARGET_DIR)/$(XFSPROGS_TARGET_BINARY)
>  Nigel> +xfsprogs: e2fsprogs libtool $(TARGET_DIR)/$(XFSPROGS_TARGET_BINARY)
>
> You need to select e2fsprogs in kconfig.

        select BR2_PACKAGE_E2FSPROGS

its already there. I have now added libuuid aswell.


>  Why do you need libtool for the
> target?
>   

I didn't add libtool-cross, I was told to use "libtool" instead in
future. Maybe the original author of xfsprogs.mk can answer why it was
there?

When I have tested it without libtool I'll send another pull request.

      reply	other threads:[~2009-12-21 12:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21  7:19 [Buildroot] [pull request] Pull request for branch xfsprogs-update Nigel Kukard
2009-12-21  7:19 ` [Buildroot] [PATCH 1/1] Update xfsprogs Nigel Kukard
2009-12-21  9:07   ` Peter Korsgaard
2009-12-21 12:02     ` Nigel Kukard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2F63CE.1000801@lbsd.net \
    --to=nkukard@lbsd.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.