All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2/trivial: Add default mask log for heartbeat.c
Date: Mon, 21 Dec 2009 14:37:15 -0800	[thread overview]
Message-ID: <4B2FF89B.3040101@oracle.com> (raw)
In-Reply-To: <1261375896-11322-1-git-send-email-tao.ma@oracle.com>

Maybe better if we changed the two mlog(0,... to mlog(ML_HEARTBEAT,...

Now I don't know why we don't have a default mask in that file but instead
have distinct mlogs for HEARTBEAT and HB_BIO. One reason could have been to
limit the logging of hb_bio. If that is correct, then adding a default mask
will defeat the purpose.

Tao Ma wrote:
> I just noticed today that we have no default mask
> prefix for fs/ocfs2/cluster/heartbeat.c, but we have
> 2 places that use "mlog(0,...)". So add the default
> prefix so that these "mlog(0, ...)" can work.
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
> ---
>  fs/ocfs2/cluster/heartbeat.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
> index c452d11..edec9bf 100644
> --- a/fs/ocfs2/cluster/heartbeat.c
> +++ b/fs/ocfs2/cluster/heartbeat.c
> @@ -40,6 +40,7 @@
>  #include "nodemanager.h"
>  #include "quorum.h"
>  
> +#define MLOG_MASK_PREFIX ML_HEARTBEAT
>  #include "masklog.h"
>  
>  
>   

  reply	other threads:[~2009-12-21 22:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21  6:11 [Ocfs2-devel] [PATCH] ocfs2/trivial: Add default mask log for heartbeat.c Tao Ma
2009-12-21 22:37 ` Sunil Mushran [this message]
2009-12-22  1:37   ` Tao Ma
2009-12-22  1:50     ` Sunil Mushran
2009-12-22  2:04       ` Tao Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2FF89B.3040101@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.