Re: [PATCH 3/4] rt-tests: Clean-up - protect rt-utils.h

[Carsten Emde <Carsten.Emde@osadl.org>]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

Clark,

>>> Clean-up: Protect rt-utils.h with #ifndef RT_UTILS_H
>>> [..]
>>> +#ifndef RT_UTILS.H
>> Macro names should only consist of alphanumeric characters and
>> underscores, i.e. 'a-z', 'A-Z', '0-9', and '_', and the first character
>> should not be a digit.
> Yeah, I caught that and also pushed it out of application name space
> with two leading underscores. 
Great.

I did some first tests on 0.58, and all works very well now. Thanks a
lot, you and John, for all the work!

As a very minor issue, the below patch still didn't make it into your
tree.

	Carsten.

-=--------------------------------------------------------------------=-
Explain in the sendme error message how to make the backfire module,
if not available.

Signed-off-by: Carsten Emde <C.Emde@osadl.org>

[-- Attachment #2: explain-howto-make-backfire-module.patch --]
[-- Type: text/x-patch, Size: 657 bytes --]

diff --git a/src/backfire/sendme.c b/src/backfire/sendme.c
index fdc1056..1f02c72 100644
--- a/src/backfire/sendme.c
+++ b/src/backfire/sendme.c
@@ -209,7 +209,12 @@ int main(int argc, char *argv[])
 	path = open("/dev/backfire", O_RDWR);
 	if (path < 0) {
 		fprintf(stderr, "ERROR: Could not access backfire device, "
-				"try 'modprobe backfire'\n");
+				"try 'modprobe backfire'.\n"
+				"If the module backfire can't be loaded, "
+				"it may need to be built first.\n"
+				"Execute 'cd src/backfire; make' in the "
+				"rt-tests directory (requires rt-tests\n"
+				"sources and kernel-devel package).\n");
 		return 1;
 	}
 	fl.l_type = F_WRLCK;