From: "Helight.Xu" <helight.xu@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Takashi Iwai <tiwai@suse.de>, Xiaotian Feng <xtfeng@gmail.com>,
Amerigo Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org,
Corentin Chary <corentincj@iksaif.net>,
ibm-acpi-devel@lists.sourceforge.net,
Len Brown <len.brown@intel.com>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
akpm@linux-foundation.org
Subject: Re: [Patch] thinkpad_acpi: fix a build error
Date: Tue, 22 Dec 2009 09:10:59 +0800 [thread overview]
Message-ID: <4B301CA3.1060704@gmail.com> (raw)
In-Reply-To: <1261435136.4041.152.camel@localhost.localdomain>
Marcel Holtmann wrote:
> Hi Henrique,
>
>
>>> The patch isn't correct (I guess the upstream fix is same?).
>>>
>>> CONFIG_SOUND is a global config for sound subsystem. The relevant
>>> functions are ALSA core part, which is CONFIG_SND.
>>> So, the fix should be:
>>>
>>> depends on SND
>>>
>>> instead.
>>>
>> Indeed. Ingo already fixed that too.
>>
>> Although I personally would prefer:
>> select SOUND
>> select SND
>>
>> But anything that stops the build errors will do for now.
>>
>
> I still haven't seen this patch in Linus' tree. And you do need select
> SOUND and SND. Otherwise you still get build errors. I have tested this
> on my machine. So can someone please submit a proper patch to get this
> fixed.
>
I think my first patch about this can fix it!
http://lkml.org/lkml/2009/12/18/141
I have tested it!
> Regards
>
> Marcel
>
>
>
>
--
Zhenwen Xu - Seven Helight
Home Page: http://zhwen.org
next prev parent reply other threads:[~2009-12-22 1:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 9:28 [Patch] thinkpad_acpi: fix a build error Amerigo Wang
2009-12-18 9:42 ` Xiaotian Feng
2009-12-18 10:15 ` Takashi Iwai
2009-12-18 12:23 ` Helight.Xu
2009-12-18 14:28 ` Henrique de Moraes Holschuh
2009-12-18 14:31 ` Takashi Iwai
2009-12-18 15:03 ` Henrique de Moraes Holschuh
2009-12-18 15:10 ` Takashi Iwai
2009-12-21 22:38 ` Marcel Holtmann
2009-12-21 22:44 ` Randy Dunlap
2009-12-22 19:38 ` Henrique de Moraes Holschuh
2009-12-23 6:41 ` Takashi Iwai
2009-12-24 18:59 ` Henrique de Moraes Holschuh
2009-12-25 11:09 ` Takashi Iwai
2009-12-25 13:41 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2009-12-25 18:39 ` Randy Dunlap
2009-12-22 1:10 ` Helight.Xu [this message]
2009-12-22 3:00 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2009-12-18 13:23 [PATCH] " Helight.Xu
2009-12-18 13:28 ` Helight.Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B301CA3.1060704@gmail.com \
--to=helight.xu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=amwang@redhat.com \
--cc=corentincj@iksaif.net \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=tiwai@suse.de \
--cc=xtfeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.