From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ma Date: Tue, 22 Dec 2009 09:37:34 +0800 Subject: [Ocfs2-devel] [PATCH] ocfs2/trivial: Add default mask log for heartbeat.c In-Reply-To: <4B2FF89B.3040101@oracle.com> References: <1261375896-11322-1-git-send-email-tao.ma@oracle.com> <4B2FF89B.3040101@oracle.com> Message-ID: <4B3022DE.1070006@oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com Sunil Mushran wrote: > Maybe better if we changed the two mlog(0,... to mlog(ML_HEARTBEAT,... > > Now I don't know why we don't have a default mask in that file but instead > have distinct mlogs for HEARTBEAT and HB_BIO. One reason could have been to > limit the logging of hb_bio. If that is correct, then adding a default mask > will defeat the purpose. yeah, I just got that two mlog(0,...) and tried to find the default mask and failed. Don't know the real reason for it. Will redo the patch as you like. But the point I don't get is that why add a default mask will have an effect on mlog(ML_HB_BIO,...)? Regards, Tao > > Tao Ma wrote: >> I just noticed today that we have no default mask >> prefix for fs/ocfs2/cluster/heartbeat.c, but we have >> 2 places that use "mlog(0,...)". So add the default >> prefix so that these "mlog(0, ...)" can work. >> >> Signed-off-by: Tao Ma >> --- >> fs/ocfs2/cluster/heartbeat.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c >> index c452d11..edec9bf 100644 >> --- a/fs/ocfs2/cluster/heartbeat.c >> +++ b/fs/ocfs2/cluster/heartbeat.c >> @@ -40,6 +40,7 @@ >> #include "nodemanager.h" >> #include "quorum.h" >> >> +#define MLOG_MASK_PREFIX ML_HEARTBEAT >> #include "masklog.h" >> >> >> >