From: Jan Kiszka <jan.kiszka@domain.hid>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Xenomai core <Xenomai-core@domain.hid>,
Wolfgang Grandegger <wg@domain.hid>
Subject: Re: [Xenomai-core] Build tests: analogy, blackfin, rtcan and nios2.
Date: Tue, 22 Dec 2009 12:36:09 +0100 [thread overview]
Message-ID: <4B30AF29.4050303@domain.hid> (raw)
In-Reply-To: <4B309A29.6030405@domain.hid>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Gilles Chanteperdrix wrote:
> * rtcan: on blackfin we seem to have a conflict with rtcan.
> The warning is about CAN_ERR_MASK, sure blackfin is a bit strange to
> define this in core headers which are included everywhere. This said,
> not prefixing a Xenomai symbol with something like XN seems to be asking
> for trouble. Wolfgang, do you think it would be possible to rename the
> symbols with such prefix? Or do you share some code with socket-can that
> you do not want to touch?
CAN_ERR_MASK is part of the Socket-CAN interface (include/linux/can.h),
it must not be called differently. Blackfin is obviously doing namespace
pollution which should be fixed upstream and meanwhile worked around in
Xenomai (e.g. via #undef CAN_ERR_MASK).
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-12-22 11:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 10:06 [Xenomai-core] Build tests: analogy, blackfin, rtcan and nios2 Gilles Chanteperdrix
2009-12-22 10:43 ` Philippe Gerum
2009-12-22 11:36 ` Jan Kiszka [this message]
2009-12-22 11:45 ` Gilles Chanteperdrix
2009-12-22 11:50 ` Wolfgang Grandegger
2009-12-22 11:55 ` Wolfgang Grandegger
2009-12-22 12:30 ` Gilles Chanteperdrix
2009-12-22 12:43 ` Jan Kiszka
2009-12-22 12:46 ` Gilles Chanteperdrix
2009-12-22 13:38 ` Wolfgang Grandegger
2009-12-22 13:10 ` Patrice Kadionik
2009-12-22 14:07 ` Patrice Kadionik
2009-12-23 12:16 ` Gilles Chanteperdrix
2009-12-23 1:03 ` Alexis Berlemont
2009-12-23 12:32 ` Gilles Chanteperdrix
2009-12-26 0:09 ` Alexis Berlemont
2009-12-26 18:09 ` Gilles Chanteperdrix
2009-12-26 18:27 ` Philippe Gerum
2009-12-26 22:54 ` Gilles Chanteperdrix
2009-12-27 0:22 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B30AF29.4050303@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=Xenomai-core@domain.hid \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=wg@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.