From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NN8xF-0004Ve-To for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:55:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NN8xA-0004Sh-Vm for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:55:29 -0500 Received: from [199.232.76.173] (port=47702 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NN8xA-0004SX-OA for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:55:24 -0500 Received: from cantor.suse.de ([195.135.220.2]:48139 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NN8x9-00036F-Tf for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:55:24 -0500 Message-ID: <4B310804.4090104@suse.de> Date: Tue, 22 Dec 2009 18:55:16 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1261504146-26018-1-git-send-email-amit.shah@redhat.com> <1261504146-26018-2-git-send-email-amit.shah@redhat.com> <1261504146-26018-3-git-send-email-amit.shah@redhat.com> In-Reply-To: <1261504146-26018-3-git-send-email-amit.shah@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: armbru@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com Amit Shah wrote: > This patch migrates virtio-console to the qdev infrastructure and > creates a new virtio-serial bus on which multiple ports are exposed as > devices. The bulk of the code now resides in a new file with > virtio-console.c being just a simple qdev device. > > This interface enables spawning of multiple virtio consoles as well as generic > serial ports. > > The older -virtconsole argument still works, but when using the new > functionality, it is recommended to use > > -device virtio-serial-pci -device virtconsole,... > > The virtconsole device type accepts a chardev as an argument and a 'name' > argument to identify the corresponding consoles on the host as well as the > guest. The name, if given, is exposed via the 'name' sysfs attribute in the > guest. > > Care has been taken to ensure compatibility with kernels that do not > support multiple ports as well as accepting incoming migrations from older > qemu versions. > > Signed-off-by: Amit Shah > Please split this patch. I got dizzy after only reading 1/4th of it :-). Alex