Re: Fix for grub_assert_fail undefined on NetBSD and other platforms

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

Grégoire Sutre wrote:
> Hi,
>
> > Unfortunately, I couldn't test this on NetBSD, where old technique was
> > reported failing as GCC optimizations didn't happen.  Can Grégoire
> > Sutr or anybody else try this out on NetBSD and confirm?
>
> Thanks for looking into this.
>
> I tested the second version of the patch.  Linking now works without
> errors but I get new warnings:
>
> ./include/grub/list.h:44: warning: 'error' attribute directive ignored
This situation is acceptable. In unlikely case that cast is indeed bad
you will get runtime error instead of compile error. But it would be a
benefit if abort message would de improved by defining intermidiate
macro while will pass __LINE__ and __FILE__ to bad_cast_real which will
use it to tell developper where there is a problem
>
> I attach the log of (./autogen.sh && ./configure && gmake grub-fstest
> LDFLAGS=-lintl).  This is on NetBSD 5.0 with gcc 4.1.3 (the default).
> If I use gcc 4.4 instead, then I do not get any warning.
>
> Grégoire
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]