From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 04/11] KVM: introduce gfn_to_pfn_memslot Date: Wed, 23 Dec 2009 14:09:50 +0200 Message-ID: <4B32088E.7050607@redhat.com> References: <20091223113833.742662117@redhat.com> <20091223114438.633057461@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36128 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754621AbZLWMJw (ORCPT ); Wed, 23 Dec 2009 07:09:52 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBNC9pmo014686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Dec 2009 07:09:52 -0500 In-Reply-To: <20091223114438.633057461@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/23/2009 01:38 PM, Marcelo Tosatti wrote: > Which takes a memslot pointer instead of using kvm->memslots. > > To be used by SRCU convertion later. > > Signed-off-by: Marcelo Tosatti > > > @@ -835,21 +835,14 @@ unsigned long gfn_to_hva(struct kvm *kvm > } > EXPORT_SYMBOL_GPL(gfn_to_hva); > > -pfn_t gfn_to_pfn(struct kvm *kvm, gfn_t gfn) > +static pfn_t __gfn_to_pfn(struct kvm *kvm, unsigned long addr) > { > That's an hva now, not a gfn; the function name should reflect this. -- error compiling committee.c: too many arguments to function