From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, gospo@redhat.com,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [ethtool PATCH] ethtool: Can't parse ints with stroul()
Date: Wed, 23 Dec 2009 16:52:39 -0500 [thread overview]
Message-ID: <4B329127.8020002@garzik.org> (raw)
In-Reply-To: <9929d2390912091712g6d0543e9y170f21712b9efb7@mail.gmail.com>
On 12/09/2009 08:12 PM, Jeff Kirsher wrote:
> On Tue, Dec 8, 2009 at 09:32, Jeff Kirsher<jeffrey.t.kirsher@intel.com> wrote:
>> From: PJ Waskiewicz<peter.p.waskiewicz.jr@intel.com>
>>
>> A recent change to how int's were being parsed from the command
>> line had them being read in with an unsigned int string operator.
>> This didn't allow signed numbers from being read in correctly.
>> This patch adds a get_uint() routine, and fixes the get_int()
>> routine to read in signed values.
>>
>> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@intel.com>
>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@intel.com>
>> ---
>>
>
> Jeff G. - hold off on this patch. We have a version 2 in the works,
> because we found if the sign bit was set on a uint, this would fail
> parsing.
Was version 2 ever posted? I never saw it...
Jeff
next prev parent reply other threads:[~2009-12-23 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 17:32 [ethtool PATCH] ethtool: Can't parse ints with stroul() Jeff Kirsher
2009-12-10 1:12 ` Jeff Kirsher
2009-12-23 21:52 ` Jeff Garzik [this message]
2009-12-23 21:58 ` Jeff Kirsher
-- strict thread matches above, loose matches on Subject: below --
2009-12-24 7:22 Jeff Kirsher
2009-12-24 8:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B329127.8020002@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.