From: Jeff Garzik <jeff@garzik.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: netdev@vger.kernel.org, Kalle Valo <kalle.valo@iki.fi>
Subject: Re: [PATCH] ethtool: add support for at76c50x-usb driver
Date: Wed, 23 Dec 2009 17:12:15 -0500 [thread overview]
Message-ID: <4B3295BF.6030809@garzik.org> (raw)
In-Reply-To: <1261578587-3547-1-git-send-email-linville@tuxdriver.com>
On 12/23/2009 09:29 AM, John W. Linville wrote:
> Signed-off-by: John W. Linville<linville@tuxdriver.com>
> ---
> Makefile.am | 2 +-
> at76c50x-usb.c | 32 ++++++++++++++++++++++++++++++++
> ethtool-util.h | 2 ++
> ethtool.c | 1 +
> 4 files changed, 36 insertions(+), 1 deletions(-)
> create mode 100644 at76c50x-usb.c
> +at76c50x_usb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
> +{
> + u8 version = (u8)(regs->version>> 24);
> + u8 rev_id = (u8)(regs->version);
> + char *ver_string;
> +
> + if (version != 0)
> + return -1;
> +
> + ver_string = hw_versions[rev_id];
> + fprintf(stdout,
> + "Hardware Version %s\n",
> + ver_string);
> +
> + return 0;
applied... don't forget to update 'version', should the register dump
data passed to userspace ever change.
prev parent reply other threads:[~2009-12-23 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 14:29 [PATCH] ethtool: add support for at76c50x-usb driver John W. Linville
2009-12-23 22:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3295BF.6030809@garzik.org \
--to=jeff@garzik.org \
--cc=kalle.valo@iki.fi \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.