From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 00/11] convert slotslock to SRCU v2
Date: Fri, 25 Dec 2009 18:27:11 +0200
Message-ID: <4B34E7DF.4070104@redhat.com>
References: <20091223163515.215618069@redhat.com> <4B3326A0.4080708@redhat.com> <20091224145638.GC5691@redhat.com> <200912251524.49261.sheng@linux.intel.com> <20091225122500.GA4693@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Sheng Yang <sheng@linux.intel.com>, kvm@vger.kernel.org,
	Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:60820 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751527AbZLYQ1Q (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 25 Dec 2009 11:27:16 -0500
In-Reply-To: <20091225122500.GA4693@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12/25/2009 02:25 PM, Marcelo Tosatti wrote:
>
>> One small comment on the naming:
>>
>> kvm->memslots->memslots[i]
>> kvm->aliases->aliases[i]
>>
>> Doesn't look good...
>>      
> Hi Sheng,
>
> Yes its somewhat confusing but i could not come up with
> anything better. Suggestions?
>    

Could all it 'mem', and put both ->memslots and ->aliases as members.  
This might simplify things a bit.

However, I don't recommend doing so now, it's just churn.  We can always 
to it later.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.