From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 00/11] convert slotslock to SRCU Date: Sun, 27 Dec 2009 15:16:00 +0200 Message-ID: <4B375E10.8050805@redhat.com> References: <20091223113833.742662117@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39256 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbZL0NQF (ORCPT ); Sun, 27 Dec 2009 08:16:05 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBRDG1j1001143 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 27 Dec 2009 08:16:01 -0500 In-Reply-To: <20091223113833.742662117@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 12/23/2009 01:38 PM, Marcelo Tosatti wrote: > Now that synchronize_srcu_expedited is in the tree, we can continue the > convertion of slots_lock to SRCU. > > Results: > up: > > Without this patchset, -smp 64 is simply unusable. An _idle_ Linux guest generates enough interrupts that the system is unable to make any progress: [root@monster01 ~]# perf report -g # Samples: 14214748264314 # # Overhead Command Shared Object Symbol # ........ ............... ................................. ...... # 40.81% qemu-system-x86 [kernel] [k] _raw_spin_lock_irq | --- _raw_spin_lock_irq | |--99.94%-- __down_read | down_read | | | |--99.82%-- 0xffffffffa00479c4 | | 0xffffffffa003a6c9 | | vfs_ioctl | | do_vfs_ioctl | | sys_ioctl | | system_call | | __GI_ioctl | --0.18%-- [...] --0.06%-- [...] 40.57% qemu-system-x86 [kernel] [k] _raw_spin_lock_irqsave | --- _raw_spin_lock_irqsave | |--99.88%-- __up_read | up_read | | | |--99.82%-- 0xffffffffa0047897 | | 0xffffffffa003a6c9 | | vfs_ioctl | | do_vfs_ioctl | | sys_ioctl | | system_call | | __GI_ioctl | --0.18%-- [...] --0.12%-- [...] With this patchset, -smp 64 flies. Patch to follow. Amazing work! (and surprising how easy it is to saturate a large system) -- error compiling committee.c: too many arguments to function