From: Roel Kluin <roel.kluin@gmail.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>, Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
John David Anglin <dave@hiauly1.hia.nrc.ca>,
linux-parisc@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parisc: test off by one in sgl_frem() and dbl_frem()
Date: Sun, 27 Dec 2009 22:11:06 +0100 [thread overview]
Message-ID: <4B37CD6A.2000506@gmail.com> (raw)
In-Reply-To: <1261927804.2697.4.camel@mulgrave.site>
Op 27-12-09 16:30, James Bottomley schreef:
> On Sun, 2009-12-27 at 14:21 +0100, Roel Kluin wrote:
>> With `while (stepcount-- > 0)' stepcount reaches -1 after the loop.
>
> This is true, but seems to be by design
>> - if (stepcount > 0 || Sgl_iszero(opnd1)) {
>> + if (stepcount >= 0 || Sgl_iszero(opnd1)) {
>
> Your patch does nothing to the actual execution flow (Sgl_iszero is true
> if stepcount == 0) ... what's the point of applying it?
>
> James
Ok, please ignore and thanks (also to Dave) for review.
Roel
prev parent reply other threads:[~2009-12-27 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-27 13:21 [PATCH] parisc: test off by one in sgl_frem() and dbl_frem() Roel Kluin
2009-12-27 13:21 ` Roel Kluin
2009-12-27 15:10 ` John David Anglin
2009-12-27 15:30 ` James Bottomley
2009-12-27 21:11 ` Roel Kluin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B37CD6A.2000506@gmail.com \
--to=roel.kluin@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=dave@hiauly1.hia.nrc.ca \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.