From: Jan Ceuleers <jan.ceuleers@computer.org>
To: David Miller <davem@davemloft.net>
Cc: ben@decadent.org.uk, romieu@fr.zoreil.com,
netdev@vger.kernel.org, 508527@bugs.debian.org
Subject: Re: [PATCH] via-velocity: Give RX descriptors to the NIC later on open or MTU change
Date: Mon, 28 Dec 2009 10:27:25 +0100 [thread overview]
Message-ID: <4B3879FD.60102@computer.org> (raw)
In-Reply-To: <20091225.182102.112589642.davem@davemloft.net>
David Miller wrote:
>> velocity_open() calls velocity_give_many_rx_descs(), which gives RX
>> descriptors to the NIC, before installing an interrupt handler or
>> calling velocity_init_registers(). I think this is very unsafe and it
>> appears to explain the bug report <http://bugs.debian.org/508527>.
>>
>> On MTU change, velocity_give_many_rx_descs() is again called before
>> velocity_init_registers(). I'm not sure whether this is unsafe but
>> it does look wrong.
>>
>> Therefore, move the calls to velocity_give_many_rx_descs() after
>> request_irq() and velocity_init_registers().
>>
>> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>> ---
>> This is untested; I don't have this hardware.
>
> Although this patch looks fine to me, I don't want to apply
> it until someone tests it.
I have successfully booted a 2.6.32.2 kernel with this patch applied on top on a PXE-booting machine with nfsroot. If you consider that to be a sufficient test then please feel free to add my
Tested-by: Jan Ceuleers <jan.ceuleers@computer.org>
Otherwise, please let me know which other tests you would like me to carry out.
Note though that I am unable to reproduce the original bug on my system.
Cheers, Jan
next prev parent reply other threads:[~2009-12-28 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 2:05 [PATCH] via-velocity: Give RX descriptors to the NIC later on open or MTU change Ben Hutchings
2009-12-26 2:21 ` David Miller
2009-12-28 9:27 ` Jan Ceuleers [this message]
2009-12-28 9:36 ` Jan Ceuleers
2010-01-04 5:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3879FD.60102@computer.org \
--to=jan.ceuleers@computer.org \
--cc=508527@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.